Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-3745] Folder - update metadata default copies the name in the title field #5923

Merged
merged 4 commits into from
Jul 29, 2020
Merged

[ACA-3745] Folder - update metadata default copies the name in the title field #5923

merged 4 commits into from
Jul 29, 2020
+32 −7

Conversation

pionnegru
Copy link
Contributor

@pionnegru pionnegru commented Jul 29, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ACA-3745

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Alfresco/alfresco-content-app#1507

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #5923 into develop will increase coverage by 0.35%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5923      +/-   ##
===========================================
+ Coverage    76.04%   76.40%   +0.35%     
===========================================
  Files          843      834       -9     
  Lines        18721    18471     -250     
  Branches      3682     3617      -65     
===========================================
- Hits         14237    14113     -124     
+ Misses        3365     3247     -118     
+ Partials      1119     1111       -8
Impacted Files Coverage Δ
.../content-services/src/lib/dialogs/folder.dialog.ts 86.79% <66.66%> (-0.97%) ⬇️
...b/extensions/src/lib/evaluators/core.evaluators.ts
lib/extensions/src/test.ts
...sions/src/lib/services/extension-loader.service.ts
lib/extensions/src/lib/services/rule.service.ts
.../components/dynamic-component/dynamic.component.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/config/extension-utils.ts
lib/extensions/src/lib/config/action.extensions.ts
...b/extensions/src/lib/services/extension.service.ts
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54df083...72941ee. Read the comment docs.

@pionnegru
Copy link
Contributor Author

/rebase

@pionnegru pionnegru force-pushed the pionnegru-ACA-3745 branch from 7245c59 to 72941ee Compare July 29, 2020 09:01
@eromano eromano merged commit f1a98cc into develop Jul 29, 2020
@eromano eromano deleted the pionnegru-ACA-3745 branch July 29, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pionnegru @codecov-commenter @eromano